[PATCH] D115668: [RISCV] Add a table for extension implications.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D115668#3194041 <https://reviews.llvm.org/D115668#3194041>, @craig.topper wrote:

> In D115668#3194038 <https://reviews.llvm.org/D115668#3194038>, @mehdi_amini wrote:
>
>> This does not build with gcc5 apparently: https://lab.llvm.org/staging/#/builders/190/builds/2632
>>
>>   llvm/lib/Support/RISCVISAInfo.cpp:715:1: error: could not convert '(const char*)"v"' from 'const char*' to 'llvm::StringLiteral'
>>   llvm/lib/Support/RISCVISAInfo.cpp:715:1: error: could not convert '(const char**)(& ImpliedExtsV)' from 'const char**' to 'llvm::ArrayRef<const char*>'
>>   llvm/lib/Support/RISCVISAInfo.cpp:715:1: error: could not convert '(const char*)"zfh"' from 'const char*' to 'llvm::StringLiteral'
>>   llvm/lib/Support/RISCVISAInfo.cpp:715:1: error: could not convert '(const char**)(& ImpliedExtsZfh)' from 'const char**' to 'llvm::ArrayRef<const char*>'
>
> Thanks. I seem to remember something about gcc 5.x and constexprs before. I’ll take a look

We might just need more curly braces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115668/new/

https://reviews.llvm.org/D115668