[PATCH] D114558: [ASan] Shared optimized callbacks implementation.

Tue Dec 14 18:39:34 PST 2021

vitalybuka added a comment.

I just landed the fix da7e9e34104e83fc792b599936a11f91faa43e18 <https://reviews.llvm.org/rGda7e9e34104e83fc792b599936a11f91faa43e18>

In D114558#3193922 <https://reviews.llvm.org/D114558#3193922>, @wolfgangp wrote:

> Hi. This patch is causing a couple of test failures on one of our internal bots which is still running Ubuntu 18.04. Do you have any idea what could be causing it? I'm posting the test output:
>
> - AddressSanitizer-x86_64-linux.TestCases.non-executable-pc.cpp
>
>   Stacktrace
>   Script:
>   --
>   : 'RUN: at line 1';      /home/siadmin/jenkins/w/opensource/opensource_build/build/./bin/clang  --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only  -m64  /home/siadmin/jenkins/w/opensource/opensource_build/working_dir/compiler-rt/test/asan/TestCases/non-executable-pc.cpp -o /home/siadmin/jenkins/w/opensource/opensource_build/build/projects/compiler-rt/test/asan/X86_64LinuxConfig/TestCases/Output/non-executable-pc.cpp.tmp
>   : 'RUN: at line 2';   not  /home/siadmin/jenkins/w/opensource/opensource_build/build/projects/compiler-rt/test/asan/X86_64LinuxConfig/TestCases/Output/non-executable-pc.cpp.tmp 0 2>&1 | FileCheck /home/siadmin/jenkins/w/opensource/opensource_build/working_dir/compiler-rt/test/asan/TestCases/non-executable-pc.cpp
>   : 'RUN: at line 3';   not  /home/siadmin/jenkins/w/opensource/opensource_build/build/projects/compiler-rt/test/asan/X86_64LinuxConfig/TestCases/Output/non-executable-pc.cpp.tmp n 2>&1 | FileCheck /home/siadmin/jenkins/w/opensource/opensource_build/working_dir/compiler-rt/test/asan/TestCases/non-executable-pc.cpp -check-prefix=CHECK -check-prefix=NON_EXEC
>   --
>   Exit Code: 1
>   
>   Command Output (stderr):
>   --
>   /home/siadmin/jenkins/w/opensource/opensource_build/working_dir/compiler-rt/test/asan/TestCases/non-executable-pc.cpp:28:15: error: NON_EXEC: expected string not found in input
>    // NON_EXEC: PC is at a non-executable region. Maybe a wild jump?
>                 ^
>   <stdin>:3:77: note: scanning from here
>   ==6109==ERROR: AddressSanitizer: SEGV on unknown address 0x604000010000 (pc 0x60400000ffff bp 0x7fff5e741a70 sp 0x7fff5e741a18 T0)
>                                                                               ^
>   <stdin>:8:15: note: possible intended match here
>   AddressSanitizer can not provide additional info.
>                 ^
>   
>   Input file: <stdin>
>   Check file: /home/siadmin/jenkins/w/opensource/opensource_build/working_dir/compiler-rt/test/asan/TestCases/non-executable-pc.cpp
>   
>   -dump-input=help explains the following input dump.
>   
>   Input was:
>   <<<<<<
>               1: AddressSanitizer:DEADLYSIGNAL 
>               2: ================================================================= 
>               3: ==6109==ERROR: AddressSanitizer: SEGV on unknown address 0x604000010000 (pc 0x60400000ffff bp 0x7fff5e741a70 sp 0x7fff5e741a18 T0) 
>   check:28'0                                                                                 X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
>               4: ==6109==The signal is caused by a READ memory access. 
>   check:28'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>               5:  #0 0x60400000ffff (<unknown module>) 
>   check:28'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>               6:  #1 0x7f16edc37bf6 in __libc_start_main /build/glibc-S9d2JN/glibc-2.27/csu/../csu/libc-start.c:310 
>   check:28'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>               7:  
>   check:28'0     ~
>               8: AddressSanitizer can not provide additional info. 
>   check:28'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   check:28'1                   ?                                    possible intended match
>               9: SUMMARY: AddressSanitizer: SEGV (<unknown module>)  
>   check:28'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>              10: ==6109==ABORTING 
>   check:28'0     ~~~~~~~~~~~~~~~~~
>   >>>>>>
>
>
>
> - SanitizerCommon-asan-x86_64-Linux.Linux.decorate_proc_maps.cpp
>
>   Stacktrace
>   Script:
>   --
>   : 'RUN: at line 1';      /home/siadmin/jenkins/w/opensource/opensource_build/build/./bin/clang  --driver-mode=g++ -gline-tables-only -fsanitize=address  -m64 -funwind-tables  -ldl -g /home/siadmin/jenkins/w/opensource/opensource_build/working_dir/compiler-rt/test/sanitizer_common/TestCases/Linux/decorate_proc_maps.cpp -o /home/siadmin/jenkins/w/opensource/opensource_build/build/projects/compiler-rt/test/sanitizer_common/asan-x86_64-Linux/Linux/Output/decorate_proc_maps.cpp.tmp
>   : 'RUN: at line 2';   env ASAN_OPTIONS=decorate_proc_maps=1  /home/siadmin/jenkins/w/opensource/opensource_build/build/projects/compiler-rt/test/sanitizer_common/asan-x86_64-Linux/Linux/Output/decorate_proc_maps.cpp.tmp 2>&1 | FileCheck /home/siadmin/jenkins/w/opensource/opensource_build/working_dir/compiler-rt/test/sanitizer_common/TestCases/Linux/decorate_proc_maps.cpp --check-prefix=CHECK-asan
>   --
>   Exit Code: 1
>   
>   Command Output (stderr):
>   --
>   /home/siadmin/jenkins/w/opensource/opensource_build/working_dir/compiler-rt/test/sanitizer_common/TestCases/Linux/decorate_proc_maps.cpp:48:16: error: CHECK-asan: expected string not found in input
>   // CHECK-asan: rw-p {{.*}} [low shadow]
>                  ^
>   <stdin>:1:1: note: scanning from here
>   00400000-00542000 r-xp 00000000 08:01 3149254 /home/siadmin/jenkins/w/opensource/opensource_build/build/projects/compiler-rt/test/sanitizer_common/asan-x86_64-Linux/Linux/Output/decorate_proc_maps.cpp.tmp
>   ^
>   <stdin>:5:44: note: possible intended match here
>   7fff7000-8fff7000 rwxp 00000000 00:18 24 /dev/shm/5194 [low shadow] (deleted)
>                                              ^
>   
>   Input file: <stdin>
>   Check file: /home/siadmin/jenkins/w/opensource/opensource_build/working_dir/compiler-rt/test/sanitizer_common/TestCases/Linux/decorate_proc_maps.cpp
>   
>   -dump-input=help explains the following input dump.
>   
>   Input was:
>   <<<<<<
>               1: 00400000-00542000 r-xp 00000000 08:01 3149254 /home/siadmin/jenkins/w/opensource/opensource_build/build/projects/compiler-rt/test/sanitizer_common/asan-x86_64-Linux/Linux/Output/decorate_proc_maps.cpp.tmp 
>   check:48'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
>               2: 00742000-00743000 r-xp 00142000 08:01 3149254 /home/siadmin/jenkins/w/opensource/opensource_build/build/projects/compiler-rt/test/sanitizer_common/asan-x86_64-Linux/Linux/Output/decorate_proc_maps.cpp.tmp 
>   check:48'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>               3: 00743000-00746000 rwxp 00143000 08:01 3149254 /home/siadmin/jenkins/w/opensource/opensource_build/build/projects/compiler-rt/test/sanitizer_common/asan-x86_64-Linux/Linux/Output/decorate_proc_maps.cpp.tmp 
>   check:48'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>               4: 00746000-0112e000 rwxp 00000000 00:00 0  
>   check:48'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>               5: 7fff7000-8fff7000 rwxp 00000000 00:18 24 /dev/shm/5194 [low shadow] (deleted) 
>   check:48'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   check:48'1                                                ?                                   possible intended match
>               6: 8fff7000-2008fff7000 ---p 00000000 00:18 26 /dev/shm/5194 [shadow gap] (deleted) 
>   check:48'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>               7: 2008fff7000-ff73b5d8000 rwxp 00000000 00:18 25 /dev/shm/5194 [high shadow] (deleted) 
>   check:48'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>               8: ff73b5d8000-ff73b6d7000 rwxp 00000000 00:00 0  
>   check:48'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>               9: ff73b6d7000-100037932000 rwxp df6ab6e0000 00:18 25 /dev/shm/5194 [high shadow] (deleted) 
>   check:48'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>              10: 100037932000-100037a31000 rwxp 00000000 00:00 0  
>   check:48'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>               .
>               .
>               .
>   >>>>>>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114558/new/

https://reviews.llvm.org/D114558