[PATCH] D115416: [lld-macho] Prevent writing map files on the critical path
    Jez Ng via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Dec 14 18:26:16 PST 2021
    
    
  
int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
================
Comment at: lld/MachO/Writer.cpp:1043-1048
+    threadFutures.emplace_back(threadPool.async(
+        [](LinkEditSection *osec) {
+          if (osec)
+            osec->finalizeContents();
+        },
+        osec));
----------------
oontvoo wrote:
> oontvoo wrote:
> > No need to enqueue a NULL `osec`
> (although I'm not sure it could ever be null here )
+1
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115416/new/
https://reviews.llvm.org/D115416
    
    
More information about the llvm-commits
mailing list