[PATCH] D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib

[Ben Langmuir via Phabricator via llvm-commits]

benlangmuir added a comment.

@mehdi_amini I'm seeing the same failure output in the llvm.c test even with my changes reverted and a clean build.   Any idea what I might be missing?  I am building with the following arguments -- they're about as close as I could get to that bot without having CUDA.

  $ cmake ../../llvm-project/llvm \
     -DLLVM_BUILD_EXAMPLES=ON \
     '-DLLVM_TARGETS_TO_BUILD=host;NVPTX' \
     -DLLVM_ENABLE_PROJECTS=mlir \
     -DMLIR_INCLUDE_INTEGRATION_TESTS=ON \
     -DBUILD_SHARED_LIBS=ON \
     -DCMAKE_BUILD_TYPE=Release \
     -DLLVM_ENABLE_ASSERTIONS=ON \
     '-DLLVM_LIT_ARGS=-v -vv' \
     -GNinja

Failure:

  FAIL: MLIR :: CAPI/llvm.c (2 of 1232)
  ******************** TEST 'MLIR :: CAPI/llvm.c' FAILED ********************
  Script:
  --
  : 'RUN: at line 10';   /Users/blangmuir/src/build-llvm/build-mlir-shared/bin/mlir-capi-llvm-test 2>&1 | /Users/blangmuir/src/build-llvm/build-mlir-shared/bin/FileCheck /Users/blangmuir/src/llvm-project/mlir/test/CAPI/llvm.c
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  + : 'RUN: at line 10'
  + /Users/blangmuir/src/build-llvm/build-mlir-shared/bin/mlir-capi-llvm-test
  + /Users/blangmuir/src/build-llvm/build-mlir-shared/bin/FileCheck /Users/blangmuir/src/llvm-project/mlir/test/CAPI/llvm.c
  /Users/blangmuir/src/llvm-project/mlir/test/CAPI/llvm.c:45:12: error: CHECK: expected string not found in input
   // CHECK: !llvm.void: 1
             ^
  <stdin>:3:21: note: scanning from here
  !llvm.ptr<i32, 4>: 1
                      ^
  <stdin>:4:42: note: possible intended match here
  LLVM ERROR: can't create type 'mlir::LLVM::LLVMVoidType' because storage uniquer isn't initialized: the dialect was likely not loaded, or the type wasn't added with addTypes<...>() in the Dialect::initialize() method.
                                           ^


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113610/new/

https://reviews.llvm.org/D113610