[llvm] 30c3aba - [llvm-profgen] Fix to use getUntrackedCallsites outside the loop

[via llvm-commits]

Author: wlei
Date: 2021-12-14T16:40:53-08:00
New Revision: 30c3aba998972aa042493e26dbe8f7cca37a30dd

URL: https://github.com/llvm/llvm-project/commit/30c3aba998972aa042493e26dbe8f7cca37a30dd
DIFF: https://github.com/llvm/llvm-project/commit/30c3aba998972aa042493e26dbe8f7cca37a30dd.diff

LOG: [llvm-profgen] Fix to use getUntrackedCallsites outside the loop

Unwinder is hoisted out in https://reviews.llvm.org/D115550, so fix the useage of getUntrackedCallsites.

Reviewed By: hoy, wenlei

Differential Revision: https://reviews.llvm.org/D115760

Added: 
    

Modified: 
    llvm/tools/llvm-profgen/PerfReader.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-profgen/PerfReader.cpp b/llvm/tools/llvm-profgen/PerfReader.cpp
index 5d7b732d41a3..df7590926122 100644
--- a/llvm/tools/llvm-profgen/PerfReader.cpp
+++ b/llvm/tools/llvm-profgen/PerfReader.cpp
@@ -435,25 +435,22 @@ static std::string getContextKeyStr(ContextKey *K,
 void HybridPerfReader::unwindSamples() {
   if (Binary->useFSDiscriminator())
     exitWithError("FS discriminator is not supported in CS profile.");
-  std::set<uint64_t> AllUntrackedCallsites;
   VirtualUnwinder Unwinder(&SampleCounters, Binary);
   for (const auto &Item : AggregatedSamples) {
     const PerfSample *Sample = Item.first.getPtr();
     Unwinder.unwind(Sample, Item.second);
-    auto &CurrUntrackedCallsites = Unwinder.getUntrackedCallsites();
-    AllUntrackedCallsites.insert(CurrUntrackedCallsites.begin(),
-                                 CurrUntrackedCallsites.end());
   }
 
   // Warn about untracked frames due to missing probes.
   if (ShowDetailedWarning) {
-    for (auto Address : AllUntrackedCallsites)
+    for (auto Address : Unwinder.getUntrackedCallsites())
       WithColor::warning() << "Profile context truncated due to missing probe "
                            << "for call instruction at "
                            << format("0x%" PRIx64, Address) << "\n";
   }
 
-  emitWarningSummary(AllUntrackedCallsites.size(), SampleCounters.size(),
+  emitWarningSummary(Unwinder.getUntrackedCallsites().size(),
+                     SampleCounters.size(),
                      "of profiled contexts are truncated due to missing probe "
                      "for call instruction.");
 }