[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/test/ThinLTO/X86/devirt_after_filtering_unreachable.ll:64
+; Check that EnableSplitLTOUnit is off, and check the content of summary information.
+; RUN: llvm-dis -o - %t3.o | FileCheck %s --check-prefix=NOENABLESPLITFLAG
+; NOENABLESPLITFLAG-DAG: !{i32 1, !"EnableSplitLTOUnit", i32 0}
----------------
This stuff is checked in other tests. Unless you are checking something specific to this test, you can remove all of this. Actually, it would be good to test here and in the earlier hybrid case that the summary for _ZN4BaseD0Ev says it is unreachable. But that's probably all you need to test.

Ditto for %t4.o


================
Comment at: llvm/test/ThinLTO/X86/devirt_after_filtering_unreachable.ll:127
+; RUN:   -r=%t3.o,_ZTS4Base, \
+; RUN:   -r=%t3.o,_ZTI4Base, 2>&1 | FileCheck %s --check-prefix=PRINT --check-prefix=THINREMARK
+
----------------
Unless you need to share only some of the check results with another invocation, just use a single check prefix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115648/new/

https://reviews.llvm.org/D115648