[PATCH] D112063: [lld][ELF] Add first bits to support relocation relaxations for AArch64

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexander-shaposhnikov added inline comments.


================
Comment at: lld/test/ELF/aarch64-adrp-ldr-got.s:97
+.global main
+main:
+  adrp    x1, :got:x
----------------
MaskRay wrote:
> Unlike Mach-O, ELF uses `_start`. Missing `_start` leads to a warning in an executable link.
> 
> If you combine the tests, lots of boilerplate (duplicate `.rodata`, duplicate `main:`, etc) can be avoided.
one day the tests will fail and debugging a small input is much, much easier.
I'd prefer to keep them separate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112063/new/

https://reviews.llvm.org/D112063