[PATCH] D115327: [WebAssembly] Fix reftype load/store match with idx from call

[Thomas Lively via Phabricator via llvm-commits]

tlively added a comment.

Code LGTM, but I don't quite understand what the bug was, so I'm not sure about the test coverage.



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1492
       Idx = Base->getOperand(1);
-      if (!Idx || GA->getNumValues() != 1 || Idx->getNumValues() != 1)
+      if (Idx.isUndef() || GA->getNumValues() != 1)
         return false;
----------------
Does the test in this revision cover this `Idx.isUndef()` case? I would have expected to see an `undef` in the IR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115327/new/

https://reviews.llvm.org/D115327