[PATCH] D115749: [WebAssembly] Emit symbol labels for table global symbols

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

My understanding is that labels like that in the assembly mean you are defining a table ... for referencing an external table it should be enough to just include a `.tabletype`.

Maybe I'm missing the motivation for this change though?



================
Comment at: llvm/test/CodeGen/WebAssembly/externref-tableset.ll:97
 
-; CHECK: .tabletype externref_table, externref
+; CHECK-LABEL: externref_table:
+;  CHECK-NEXT: .tabletype externref_table, externref
----------------
Wouldn't this line be declaring a defined table rather than an external/undefined one?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115749/new/

https://reviews.llvm.org/D115749