[PATCH] D115568: [lld] Use `GNUInstallDirs` to support custom installation dirs.

[John Ericson via Phabricator via llvm-commits]

Ericson2314 marked an inline comment as done.
Ericson2314 added inline comments.


================
Comment at: lld/cmake/modules/CMakeLists.txt:29-39
+function(extend_delayed_install_path joined_path current_segment)
+  if("${current_segment}" STREQUAL "")
+    set(temp_path "\${LLD_INSTALL_PREFIX}")
+  elseif(IS_ABSOLUTE "${current_segment}")
+    message(WARNING "Since \"${current_segment}\" is absolute, it overrides LLD_INSTALL_PREFIX")
+    set(temp_path "${current_segment}")
+  else()
----------------
Ericson2314 wrote:
> phosek wrote:
> > Could we move this to a top-level CMake module in https://github.com/llvm/llvm-project/tree/main/cmake/Modules so we can avoid duplicating this logic in every subproject?
> Oh I didn't realize there was such a top-level dir, great!
This is now done, and I rebased it atop D115746 which does something similar.

(we removed similar project-wide prefix variables in libc++, libc++abi, and libc++ before, but I suppose now that we have this function, if someone were to chime in that they wanted them back after all, it wouldn't be such a nuisance to support.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115568/new/

https://reviews.llvm.org/D115568