[PATCH] D113578: [SCEV] Apply loop guards when computing max BTC for arbitrary steps.

Alexander Kornienko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 14 08:42:48 PST 2021


alexfh added a comment.

In D113578#3191883 <https://reviews.llvm.org/D113578#3191883>, @fhahn wrote:

> Thanks for the heads-up, I'll take a look now. But from the stack trace you shared, I doubt that the patch itself is causing the crash, but rather exposes an existing bug in `GetMinTrailingZeros`/`computeKnownBits`

Right, I've seen this sort of stuff a few times recently. I guess, in a sufficiently complex system this is not a rare occasion. Unfortunately, the burden of mitigating the underlying issue in practice frequently lies with the author of the patch exposing the issue (unless someone else volunteers to do this).

Do you see an obvious fix for the bug you mentioned or should we revert this patch while you're investigating?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113578/new/

https://reviews.llvm.org/D113578



More information about the llvm-commits mailing list