[PATCH] D115737: [IPSCCP] Partial support for constrained intrinsics

[Florian Hahn via Phabricator via llvm-commits]

fhahn requested changes to this revision.
fhahn added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/IR/Instruction.cpp:694
 bool Instruction::isSafeToRemove() const {
+  if (const auto *CI = dyn_cast<ConstrainedFPIntrinsic>(this)) {
+    Optional<fp::ExceptionBehavior> EB = CI->getExceptionBehavior();
----------------
I think this change is strictly independent of supporting constrained intrinsics in SCCP and should be separate I think.


================
Comment at: llvm/test/Transforms/SCCP/strictfp-float-nan-simplification.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -passes=sccp -S %s | FileCheck %s
----------------
could you preocmmit the tests?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115737/new/

https://reviews.llvm.org/D115737