[PATCH] D114959: Print target inline asm memory constraints

[Boris Boesler via Phabricator via llvm-commits]

borisboesler added inline comments.


================
Comment at: llvm/include/llvm/IR/InlineAsm.h:266
     Constraint_Zy,
     Constraints_Max = Constraint_Zy,
     Constraints_ShiftAmount = 16,
----------------
kschwarz wrote:
> As far as I understand, upstream targets define their (target) specific memory constraints in this common enum.
> The Constraints_Max value is used in the assertion to make sure all upstream constraints are handled properly.
> 
> Why do you need to remove the assertion upstream? I would rather expect your downstream target to add more values to this enum, and to handle them in `getMemConstraintName`.
Why should we add target related things in `llvm/IR`? We do not add target opcodes in `llvm/IR/ISDOpcodes.h`. I propose to keep target related code in their target codebase.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114959/new/

https://reviews.llvm.org/D114959