[llvm] 6fef0ff - Revert unnecessary and incorrect change made to GraphWriter

[Jamie Schmeiser via llvm-commits]

Author: Jamie Schmeiser
Date: 2021-12-14T08:42:35-05:00
New Revision: 6fef0ffa14a38c2146c395cc4f39d80844ecc639

URL: https://github.com/llvm/llvm-project/commit/6fef0ffa14a38c2146c395cc4f39d80844ecc639
DIFF: https://github.com/llvm/llvm-project/commit/6fef0ffa14a38c2146c395cc4f39d80844ecc639.diff

LOG: Revert unnecessary and incorrect change made to GraphWriter

Summary:
As pointed out in https://github.com/llvm/llvm-project/issues/52610, the
changes to GraphWriter made in https://reviews.llvm.org/D87202 introduced
some bad code and the changes are actually unnecessary for
-print-changed=dot-cfg. The code in question is guarded by a call to
DefaultDOTGraphTraits::hasEdgeDestLabels() which is always false when the
graph writer is called for -print-changed=dot-cfg. Revert this section of
the changes.

Author: Jamie Schmeiser <schmeise at ca.ibm.com>
Reviewed By:jrtc27(Jessica Clarke), xgupta(Shivam Gupta)
Differential Revision: https://reviews.llvm.org/D115649

Added: 
    

Modified: 
    llvm/include/llvm/Support/GraphWriter.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Support/GraphWriter.h b/llvm/include/llvm/Support/GraphWriter.h
index 11a31bf401606..1c0f5f702c6d9 100644
--- a/llvm/include/llvm/Support/GraphWriter.h
+++ b/llvm/include/llvm/Support/GraphWriter.h
@@ -265,10 +265,9 @@ class GraphWriter {
           << DOT::EscapeString(DTraits.getEdgeDestLabel(Node, i));
       }
 
-      if (RenderUsingHTML)
-        O << "<td colspan=\"1\">... truncated</td>";
-      else if (i != e)
-        O << "|<d64>truncated...}";
+      if (i != e)
+        O << "|<d64>truncated...";
+      O << "}";
     }
 
     if (RenderUsingHTML)