[PATCH] D115683: [clang][OpenMP] Add codegen for allocate directive's 'align' clause

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:12324
                            SourceLocation::UIntTy LocEncoding, Address Addr,
-                           const Expr *Allocator)
+                           llvm::Value *Allocator)
           : RTLFn(RTLFn), LocEncoding(LocEncoding), Addr(Addr),
----------------
I would recommend to keep `Expr *` here rather than `Value *`. `Value *Allocator` might be not reachable here (with exceptions, especially), better to reemit it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115683/new/

https://reviews.llvm.org/D115683