[PATCH] D115234: [M68k] Adopt the new VarLenCodeEmitterGen for arithmetic instructions

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added inline comments.


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kMCCodeEmitter.cpp:95-99
+    uint32_t Val = RI->getEncodingValue(RegNum);
+    // Setup the D/A bit
+    if (M68kII::isAddressRegister(RegNum))
+      Val |= 0b1000;
+    Value |= Val;
----------------
ricky26 wrote:
> Is there any reason we can't do this? (Does it perform any worse against APInt?)
> 
> Very minor but it reads slightly better to me.
> Does it perform any worse against APInt?

nah I don't think so.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115234/new/

https://reviews.llvm.org/D115234