[PATCH] D115234: [M68k] Adopt the new VarLenCodeEmitterGen for arithmetic instructions
Ricky Taylor via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 14 02:08:23 PST 2021
ricky26 accepted this revision.
ricky26 added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kMCCodeEmitter.cpp:95-99
+ uint32_t Val = RI->getEncodingValue(RegNum);
+ // Setup the D/A bit
+ if (M68kII::isAddressRegister(RegNum))
+ Val |= 0b1000;
+ Value |= Val;
----------------
Is there any reason we can't do this? (Does it perform any worse against APInt?)
Very minor but it reads slightly better to me.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115234/new/
https://reviews.llvm.org/D115234
More information about the llvm-commits
mailing list