[PATCH] D115668: [RISCV] Add a table for extension implications.

[Yueh-Ting Chen via Phabricator via llvm-commits]

eopXD added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:722
 
-  if (HasV) {
-    auto Version = findDefaultVersion("zvlsseg");
-    addExtension("zvlsseg", Version->Major, Version->Minor);
-  }
-
-  if (HasZfh) {
-    auto Version = findDefaultVersion("zfhmin");
-    addExtension("zfhmin", Version->Major, Version->Minor);
+  for (auto &Ext : Exts) {
+    auto I = llvm::lower_bound(ImpliedExts, Ext.first,
----------------
eopXD wrote:
> I think this won't cover recursive dependencies?
> Additionally, Calling `addExtension` will invalidate the range of `Exts`.
> Maybe the "work list way" I did on the `zvl` patch is more correct than this single for loop?
The comment don't need to be addressed. It is a problem D108694 will deal with,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115668/new/

https://reviews.llvm.org/D115668