[PATCH] D115635: [llvm-objcopy] Fix handling of MIPS64 little endian files

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Looks good, with @MaskRay's comment.



================
Comment at: llvm/test/tools/llvm-objcopy/ELF/mips64.test:1
+# RUN: yaml2obj %s -DENDIANNESS=ELFDATA2LSB -o %t1-le
+# RUN: llvm-objcopy %t1-le %t2-le
----------------
MaskRay wrote:
> Add a comment like `## mips64el has a special encoding of the r_info relocation field. Test that we support both endianness.`
I assume that yaml2obj does actually generate the r_info correctly in this case? Easiest way to tell is to make sure the test fails without this fix, if you're not sure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115635/new/

https://reviews.llvm.org/D115635