[PATCH] D114590: [CodeGen] Emit alignment "Max Skip" operand for align directives

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineBlockPlacement.cpp:3416
 
   if (AlignAllBlock)
     // Align all of the blocks in the function to a specific alignment.
----------------
Should the MaxBytes option be used for these alignments too, if we are adding the option?


================
Comment at: llvm/test/CodeGen/AArch64/aarch64-p2align-max-bytes.ll:5-6
+; RUN: llc -mtriple=aarch64-none-linux-gnu -max-bytes-for-alignment=8 --align-loops=32 < %s -o - --filetype=obj | llvm-objdump --arch=aarch64  -d -| FileCheck %s --check-prefixes=CHECK-OBJ,CHECK-OBJ-IMPLICIT
+
+define i32 @a(i32 %x, i32* nocapture readonly %y, i32* nocapture readonly %z) {
+; CHECK-LABEL: a:
----------------
Can you add a comment explaining what this is testing. It might be a bit awkward to maintain if the codegen changes and a comment explaining what this is testing will help with that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114590/new/

https://reviews.llvm.org/D114590