[PATCH] D115668: [RISCV] Add a table for extension implications.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:698
 
+static const char *ImpliedExts_v[] = {"zvlsseg"};
+static const char *ImpliedExts_zfh[] = {"zfhmin"};
----------------
eopXD wrote:
> Will the variables with underscore violate the naming conventions in LLVM?
Yeah. Maybe I should use `ImpliedExtsV` and `ImpliedExtsZfh` so that a capital letter is against the `ImpliedExts` part for readability?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115668/new/

https://reviews.llvm.org/D115668