[PATCH] D115417: [LTO] Fix incomplete optimization remarks for dead functions when PreOptModuleHook or PostInternalizeModuleHook is defined

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 13 19:18:10 PST 2021


MaskRay added inline comments.


================
Comment at: lld/test/ELF/lto/Inputs/opt-remarks-incomplete.ll:1
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
----------------
Use `split-file` to avoid the auxiliary file.


================
Comment at: lld/test/ELF/lto/opt-remarks-incomplete.ll:1
+; REQUIRES: x86
+; RUN: opt -module-summary %s -o %t1.o
----------------
Add a file-level comment about the purpose of the test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115417/new/

https://reviews.llvm.org/D115417



More information about the llvm-commits mailing list