[PATCH] D111555: [LoopVectorize] Add vector reduction support for fmuladd intrinsic

Mindong Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 13 18:58:24 PST 2021


mdchen added a comment.

@RosieSumpter Thanks for the patch! I'm in question that whether `llvm.fma.*` should also be considered a valid candidate here. LangRef describes that

> If a fused multiply-add is required, the corresponding llvm.fma intrinsic function should be used instead.

I'm not sure if this is a restriction that `fma` should not be expanded into `mul+add` by other passes which consider the transformation profitable, like LoopVectorize in this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111555/new/

https://reviews.llvm.org/D111555



More information about the llvm-commits mailing list