[PATCH] D115413: [amdgpu] Drop lowering of LDS used by global variables

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

Will land this shortly.

I think a significant missing piece of LDS testing is code that runs on the GPU. We have some coarse coverage through the openmp tests (because the openmp runtime happens to make fairly heavy use of LDS) but I'm not aware of any targeted testing. I'm planning to add some through openmp, syntax comes out as

  uint64_t var __attribute__((loader_uninitialized));
  #pragma allocate(var) allocator(omp_pteam_mem_alloc)

but it's not going to be as precise as it could be through a runtime that doesn't use LDS, will see if I can find some hip or opencl tests that run in tree.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115413/new/

https://reviews.llvm.org/D115413