[PATCH] D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D113610#3190679 <https://reviews.llvm.org/D113610#3190679>, @rnk wrote:

> In D113610#3190673 <https://reviews.llvm.org/D113610#3190673>, @MaskRay wrote:
>
>> LLVM_BUILD_LLVM_DYLIB is a cmake variable, not a C/C++ macro. You may need to change `include/llvm/Config/llvm-config.h.cmake`
>
> I believe that is included already, if I'm not mistaken.

I have checked a `-DLLVM_LINK_LLVM_DYLIB=on` (which implies `-DLLVM_BUILD_LLVM_DYLIB=on`) build. It is not.

  #ifdef LLVM_EXTERNAL_VISIBILITY                                                                                     
    puts("LLVM_EXTERNAL_VISIBILITY");                                                                                 
  #endif                                                    
  #ifdef LLVM_BUILD_LLVM_DYLIB                              
    puts("LLVM_BUILD_LLVM_DYLIB");                                                                                    
  #endif

`ninja -C /tmp/out/custom1 llvm-strings; /tmp/out/custom1/bin/llvm-strings --help` I see `LLVM_EXTERNAL_VISIBILITY` but not `LLVM_BUILD_LLVM_DYLIB`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113610/new/

https://reviews.llvm.org/D113610