[PATCH] D115559: AMDGPU: Propagate amdgpu-waves-per-eu with attributor

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I don't understand all the update logic but from an Attributor standpoint there are only two things that should be addressed.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:680
+    ConstantRange Range(APInt(32, Min), APInt(32, Max + 1));
+    intersectKnown(Range);
+  }
----------------
Somewhat surprising you intersect the known range with an assumed result, if that is on purpose probably worth a comment explaining why this is reasonable.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:714
+    if (!A.checkForAllCallSites(CheckCallSite, *this, true, AllCallSitesKnown))
+      indicatePessimisticFixpoint();
+
----------------
It is important to return "CHANGED" here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115559/new/

https://reviews.llvm.org/D115559