[PATCH] D115413: [amdgpu] Drop lowering of LDS used by global variables

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

I am doubtful that this would be the correct strategy for initializers of LDS - I suspect that's going to have to be handled by injecting initialisation code into the prologue of kernels and changing the initialisers to undef - but even if it is, we can retrieve it from git at will. Right now it makes callgraph crawling to avoid unnecessary allocation of LDS much more complicated (or imprecise).

I definitely agree that LDS handling is under-tested at present but there's no value I can see to these specific tests. They'll need to be changed to be more useful at which point we're better off deciding what it is we want to check and writing tests that hit that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115413/new/

https://reviews.llvm.org/D115413