[PATCH] D113086: [flang] Add a semantics test for co_reduce

Mon Dec 13 13:51:24 PST 2021

ekieri accepted this revision.
ekieri added a comment.
This revision is now accepted and ready to land.

In D113086#3183917 <https://reviews.llvm.org/D113086#3183917>, @ekieri wrote:

> I'll try to find time for another look within the next few days. Please don't forget to answer @clementval 's inline comment, and mark mine as done if you fixed it. And I would prefer if you add a TODO comment in the file header about tests for 'result_image', 'stat', and 'errmsg'.

Now I've read it properly, and see I misunderstood you. The tests for result_image, stat, errmsg are there, and look good. I interpreted you as if you were to put them in a different revision (probably because I would have done it that way), but they're here, they're fine, and I think it works just as good to do it this way. Sorry about that.

I added two tiny nits inline (typos in comments). LGTM, as long as @clementval's question is answered. But please give it a day or so in case Valentin or @kiranchandramohan, or somebody else, has something to add. Thanks for working on this!

================
Comment at: flang/test/Semantics/collectives05.f90:95
+
+  ! operation's arguments must scalars
+  !ERROR: (message to be determined)
----------------

================
Comment at: flang/test/Semantics/collectives05.f90:119
+
+  ! arguments must non-optional
+  !ERROR: (message to be determined)
----------------

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113086/new/

https://reviews.llvm.org/D113086