[PATCH] D115387: [instcombine] Canonicalize constant index type to i64 for extractelement/insertelement

[Philip Reames via Phabricator via llvm-commits]

reames abandoned this revision.
reames added a comment.

I'm abandoning work on this.  Sorry for doing that for an already approved patch, but the work required to finish the last update on the test turns out to be significantly more than I'd thought, and just isn't worth it.

The clang tests effected by this seem to be primarily intrinsic tests.  These tests don't autogenerate correctly, despite claiming to be autogened.  A single attempt at autogenning them takes more than an hour of runtime.  The tests check both IR and assembly.  Each test contains hundreds of sub-tests, so updating them by hand is not really an option.

IMHO, these intrinsic tests should not be in tree.  I'm frustrated enough at the moment to just delete them, but that hardly seems like a constructive response.  Given that, I'm just going to walk away since this patch was solely motivated by a desire to cleanup from the beginning.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115387/new/

https://reviews.llvm.org/D115387