[PATCH] D115480: [InstCombine] Fold icmp of truncated left shift

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

There are a lot of tests here using different bit-widths, but they don't add much value. As suggested, we'd get more impact by varying types/uses (hint: if you're only creating 1 instruction, then extra uses of the intermediate values are almost always ok).

Also, as noted in the bug report, the compare to 0 is possibly a special-case of a more general pattern. Did you consider handling something like this:
https://alive2.llvm.org/ce/z/6SCoJu ?

Finally, if you don't have commit access yet, you probably have enough commits now to request it:
https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115480/new/

https://reviews.llvm.org/D115480