[PATCH] D115413: [amdgpu] Drop lowering of LDS used by global variables

Jon Chesterfield via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 13 11:16:37 PST 2021


JonChesterfield added a comment.

I can change the IR tests to ones that run to the backend (instead of just this pass) and see how that behaves. Might crash, might write nonsense to .data. That's strictly an increase in coverage to what we have now, with or without this patch.

It seems unfortunate that we don't have an amdgpu specific verifier pass that rejects invalid addrspace annotated variables.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115413/new/

https://reviews.llvm.org/D115413



More information about the llvm-commits mailing list