[PATCH] D115649: Revert unnecessary and incorrect change made to GraphWriter

[Jamie Schmeiser via Phabricator via llvm-commits]

jamieschmeiser created this revision.
jamieschmeiser added reviewers: jrtc27, aeubanks.
Herald added a subscriber: dexonsmith.
jamieschmeiser requested review of this revision.
Herald added a project: LLVM.

As pointed out in https://github.com/llvm/llvm-project/issues/52610, the changes to GraphWriter made
in https://reviews.llvm.org/D87202 introduced some bad code and the changes are actually unnecessary
for -print-changed=dot-cfg.  The code in question is guarded by a call to
DefaultDOTGraphTraits::hasEdgeDestLabels() which is always false when the graph writer is called for
-print-changed=dot-cfg.  Revert this section of the changes.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D115649

Files:
  llvm/include/llvm/Support/GraphWriter.h


Index: llvm/include/llvm/Support/GraphWriter.h
===================================================================
--- llvm/include/llvm/Support/GraphWriter.h
+++ llvm/include/llvm/Support/GraphWriter.h
@@ -265,10 +265,9 @@
           << DOT::EscapeString(DTraits.getEdgeDestLabel(Node, i));
       }
 
-      if (RenderUsingHTML)
-        O << "<td colspan=\"1\">... truncated</td>";
-      else if (i != e)
-        O << "|<d64>truncated...}";
+      if (i != e)
+        O << "|<d64>truncated...";
+      O << "}";
     }
 
     if (RenderUsingHTML)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115649.393952.patch
Type: text/x-patch
Size: 553 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211213/4957e6cb/attachment.bin>