[PATCH] D115635: [llvm-objcopy] Fix handling of MIPS64 little endian files

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 13 09:36:57 PST 2021


atanasyan marked 6 inline comments as done.
atanasyan added a comment.

> Since the "Mips64EL" property is a property of the input object, I wonder if we should just make it a member of the object,
> and then put a reference to that object in the relocation sections, so that we can query that, rather than needing
> to a) pass around the variable, and b) have to have the property in the relocation section? What do you think?

Agreed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115635/new/

https://reviews.llvm.org/D115635



More information about the llvm-commits mailing list