[PATCH] D115642: [CSSPGO] Warn instead of error out for modules that are not probed.

Mon Dec 13 09:36:37 PST 2021

wenlei added a comment.

> Modules that are not compiled with pseudo probe enabled can reference functions that are probed, cause those functions imported into the non-probed module.

If module is not compiled with probe, we would run into problem even if there's no importing at all, right? The problem seems to be that we're loading csspgo profile (have a valid reader) for that module without probe.

The purpose of the original change it to make sure csspgo is always 100% effective, and if not, we should fix the build. With this change, how do we make sure that is still the case? i.e. we can now pass csspgo profile to a build without adding pseudo-probe flag, and the build will still succeed, right?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115642/new/

https://reviews.llvm.org/D115642