[PATCH] D115574: [ThinLTO] Fix nondeterministic exit on error.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 13 09:34:00 PST 2021


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

lgtm with one minor suggestion below.



================
Comment at: llvm/tools/llvm-lto2/llvm-lto2.cpp:324
+    errs() << '\n';
+    if (DI.getSeverity() != DS_Error)
+      return;
----------------
Nit: The last 3 lines can now be shortened to 2:

```
if (DI.getSeverity() == DS_Error)
   HasErrors = true;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115574/new/

https://reviews.llvm.org/D115574



More information about the llvm-commits mailing list