[PATCH] D115636: [LegalizeVectorOps] code refactor for LegalizeOp - NFC

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 13 09:33:43 PST 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp:273
+    if (LD->getMemoryVT().isVector() && ExtType != ISD::NON_EXTLOAD)
+      Action = TLI.getLoadExtAction(LD->getExtensionType(), LD->getValueType(0),
+                                    LD->getMemoryVT());
----------------
This can reuse ExtType.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp:274
+      Action = TLI.getLoadExtAction(LD->getExtensionType(), LD->getValueType(0),
+                                    LD->getMemoryVT());
+    break;
----------------
Put MemoryVT in a local variable instead of calling getMemoryVT twice


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115636/new/

https://reviews.llvm.org/D115636



More information about the llvm-commits mailing list