[PATCH] D115418: [dwarf][NFC] Move expandBundle() to MachO.h

[Ellis Hoag via Phabricator via llvm-commits]

ellis added inline comments.


================
Comment at: llvm/include/llvm/Object/MachO.h:655-657
+  /// Returns true if the input path is a .dSYM bundle (as created by the
+  /// dsymutil tool) and populates `BinaryPaths` with paths to the object files
+  /// that are inside the bundle.
----------------
jhenderson wrote:
> jhenderson wrote:
> > Probably need to distinguish when the fails with an error versus when it will return false, in the comments.
> I don't think the updated comment actually resolves this point. Without looking at the function signature for a moment, this comment implies that one of two things will be returned: either an empty vector or a non-empty vector, so returning an `Expected` isn't expected from the comment. I think it would be useful to add something high-level to explain when an error might be returned.
Thanks, I've updated the comment to explain when an error is returned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115418/new/

https://reviews.llvm.org/D115418