[PATCH] D115574: [ThinLTO] Fix nondeterministic exit on error.
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 13 09:13:58 PST 2021
tejohnson added inline comments.
================
Comment at: llvm/tools/llvm-lto2/llvm-lto2.cpp:311
llvm::heavyweight_hardware_concurrency(Threads));
+ const bool SingleThreaded = ThinLTODistributedIndexes;
+ // Track whether we hit an error; in particular, in the multi-threaded case,
----------------
Or if Threads==1
================
Comment at: llvm/tools/llvm-lto2/llvm-lto2.cpp:327
+ return;
+ if (SingleThreaded)
+ exit(1);
----------------
What is the downside of always deferring the error?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115574/new/
https://reviews.llvm.org/D115574
More information about the llvm-commits
mailing list