[PATCH] D115234: [M68k] Adopt the new VarLenCodeEmitterGen for arithmetic instructions

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 13 07:46:55 PST 2021


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/M68k/MCTargetDesc/M68kMCCodeEmitter.cpp:91
+                                          const MCSubtargetInfo &STI) const {
+  assert(Op.isValid());
+
----------------
Can this be replaced with (and add an assert message):

assert(Op.isValid() && (Op.isReg() || (Op.isImm()) && "Unsupported operand type");


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115234/new/

https://reviews.llvm.org/D115234



More information about the llvm-commits mailing list