[PATCH] D115638: [OpenMPIRBuilder] Support opaque pointers in reduction handling
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 13 07:29:19 PST 2021
nikic created this revision.
nikic added reviewers: opaque-pointers, ftynse, Meinersbur, jdoerfert.
Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dexonsmith, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, guansong, hiraditya, yaxunl.
nikic requested review of this revision.
Herald added subscribers: llvm-commits, sstefan1, stephenneuendorffer, nicolasvasilache.
Herald added projects: MLIR, LLVM.
Make the reduction handling in OpenMPIRBuilder compatible with opaque pointers by explicitly storing the element type in ReductionInfo, and also passing it to the atomic reduction callback, as at least the ones in the test need the type there.
This doesn't make things fully compatible yet, there are other uses of element types in this class. I also left one getPointerElementType() call in mlir, because I'm not familiar with that.
https://reviews.llvm.org/D115638
Files:
llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp
mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115638.393891.patch
Type: text/x-patch
Size: 11775 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211213/b8b40f83/attachment.bin>
More information about the llvm-commits
mailing list