[PATCH] D115519: [llvm][docs] Describe how to work with patch series on Phabricator

[David Spickett via Phabricator via llvm-commits]

DavidSpickett added inline comments.


================
Comment at: llvm/docs/Phabricator.rst:141-144
+A recommended workflow is to interactively rebase back to the first commit
+for review. Marking that and all your subsequent commits to be
+edited. At each commit make the necessary changes, submit with arc or the web
+interface and then continue the rebase.
----------------
awarzynski wrote:
> jhenderson wrote:
> > I'm not entirely convinced this paragraph is a) that useful, and b) all that understandable. A recommended workflow for what? Assuming "creating a commit series", in which case, what does "make the necessary changes" mean in this case?
> > I'm not entirely convinced this paragraph is (...) that useful,
> 
> I think that adding a paragraph like this is very helpful. People frequently ask: "how do it do this with `arc`?" and this paragraph provides an answer.
> 
> 
> > A recommended workflow for what? 
> 
> @DavidSpickett Perhaps just clarify that this is for rebasing/updating a series of patches on Phabricator with `arc`? Basically, the first paragraph in this patch is about the basics (i.e. how to **create** a series of patches) and this paragraph is about **updating** a series of patches, right?
> 
> Also, perhaps rephrase "A recommended" as "One frequently used"? Personally I don't mind too much, but some people might not like any Arcanist-related recommendations :) 
> and this paragraph is about updating a series of patches, right?

You could use it for both. That's what I do personally but perhaps just because I could never figure out how to stop arc combining commits. Maybe once you've got a series setup, it knows not to because of the differential links?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115519/new/

https://reviews.llvm.org/D115519