[PATCH] D115603: [ELF] Remove needsPltAddr in favor of needsCopy

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 13 03:54:22 PST 2021


peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.

LGTM, although worth waiting a bit to see what others think.

I'm still wondering if we can find a better name than `needsCopy`; I still haven't come up with a better one. It would need a word that captures the abstraction of a "copy relocation" and "canonical PLT entry" without being so close to one of them that it implies just that one thing yet self descriptive on what the need is for. The best I can come up with is `needsCanonicalDefinition` but not sure that is better than `needsCopy`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115603/new/

https://reviews.llvm.org/D115603



More information about the llvm-commits mailing list