[PATCH] D115614: [MachineOutliner] Don't outline functions with the "patchable-function-entry" attribute

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 13 02:00:21 PST 2021


MaskRay created this revision.
MaskRay added a reviewer: paquette.
Herald added subscribers: luke957, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya.
MaskRay requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

MachineOutliner may outline a "patchable-function-entry" function whose body has
a TargetOpcode::PATCHABLE_FUNCTION_ENTER MachineInstr. This is incorrect because
the special code sequence must stay unchanged to be used at run-time.
Avoid outlining PATCHABLE_FUNCTION_ENTER. While here, avoid outlining FENTRY_CALL too
(which doesn't produce currently) to allow phase ordering flexibility.

Fixes #52635


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D115614

Files:
  llvm/include/llvm/CodeGen/TargetInstrInfo.h
  llvm/lib/CodeGen/TargetInstrInfo.cpp
  llvm/lib/Target/AArch64/AArch64InstrInfo.cpp
  llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
  llvm/test/CodeGen/AArch64/machine-outliner-patchable.ll
  llvm/test/CodeGen/RISCV/machine-outliner-patchable.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115614.393816.patch
Type: text/x-patch
Size: 8561 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211213/722484b2/attachment.bin>


More information about the llvm-commits mailing list