[PATCH] D114950: [RISCV] Promote large integers to constant pool

Mon Dec 13 01:42:12 PST 2021

pcwang-thead marked 2 inline comments as done.
pcwang-thead added a comment.

In D114950#3182702 <https://reviews.llvm.org/D114950#3182702>, @asb wrote:

> There's a question of what to do about some of the imm.ll test cases. Perhaps it makes sense to add an option to either change the threshold or disable the constant pool, then some of these tests can still usefully check the materialisation logic and it's easier for people to experiment with different thresholds if their microarch might benefit? I'd be open to counter-arguments that it's not worth the hassle though.

I am agree with you and I have added two options (one to disable promotion and another to set threshold).

Currently, promotion is disabled in `imm.ll`, is there any other tests that should also be disabled?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114950/new/

https://reviews.llvm.org/D114950