[PATCH] D114770: [LNT] Combine perf data metrics from several files

[Pavel Kosov via Phabricator via llvm-commits]

kpdev42 marked 5 inline comments as done.
kpdev42 added inline comments.


================
Comment at: lnt/testing/profile/perf.py:48
+            data = {}
+            for fname in glob.glob("%s*" % f):
+                cur_data = cPerf.importPerf(fname, objdump, binaryCacheRoot)
----------------
cmatthews wrote:
> cmatthews wrote:
> > This functionality needs a unit test. 
> > 
> > 
> Could this glob be any more specific?
Could you please clarify a little bit - how this test should looks like? Because `glob.glob("%s*" % f)` where `f` - is (e.g.) `somefile.perf_data` just returns all `somefile.perf_data*` files 


================
Comment at: lnt/testing/profile/perf.py:48
+            data = {}
+            for fname in glob.glob("%s*" % f):
+                cur_data = cPerf.importPerf(fname, objdump, binaryCacheRoot)
----------------
kpdev42 wrote:
> cmatthews wrote:
> > cmatthews wrote:
> > > This functionality needs a unit test. 
> > > 
> > > 
> > Could this glob be any more specific?
> Could you please clarify a little bit - how this test should looks like? Because `glob.glob("%s*" % f)` where `f` - is (e.g.) `somefile.perf_data` just returns all `somefile.perf_data*` files 
> Could this glob be any more specific?

I think no, because name of profile file can be quite different


Repository:
  rLNT LNT

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114770/new/

https://reviews.llvm.org/D114770