[PATCH] D114225: Add JSONScopedPrinter to llvm-readelf

Mon Dec 13 00:18:48 PST 2021

jhenderson added a comment.

In D114225#3186298 <https://reviews.llvm.org/D114225#3186298>, @Jaysonyan wrote:

> In D114225#3186242 <https://reviews.llvm.org/D114225#3186242>, @thakis wrote:
>
>> The test fails on Windows: http://45.33.8.238/win/50629/step_11.txt
>>
>> Please take a look and revert for now if it takes a while to fix.
>
> Thank you for the heads up, I'm taking a look now, hopefully I'll have a fix soon and if not I'll revert these changes.

An alternative test fix (and arguably a better one), would be to `cd` into the `%t.dir` directory after creating it, and then running all operations relative to the cwd, rather than the absolute paths `%t` translates into. You might want to consider making that change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114225/new/

https://reviews.llvm.org/D114225