[PATCH] D115278: Check subrange liveness at rematerialization

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 9 11:52:13 PST 2021


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveRangeEdit.cpp:146-148
+        LM &= ~SR.LaneMask;
+        if (LM.none())
+          break;
----------------
This isn't required?


================
Comment at: llvm/test/CodeGen/AMDGPU/remat-dead-subreg.mir:3
+# RUN: llc -march=amdgcn -start-before=greedy -stop-after=virtregrewriter -stress-regalloc=3 -verify-machineinstrs -o - %s | FileCheck -check-prefix=GCN %s
+
+---
----------------
Should include a brief description


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115278/new/

https://reviews.llvm.org/D115278



More information about the llvm-commits mailing list