[PATCH] D115550: [CSSPGO][llvm-profgen] Fix external address issues of perf reader (return to external addr part)

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 12 23:37:18 PST 2021


wenlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/PerfReader.h:317
+      CurrentLeafFrame = CurrentLeafFrame->Parent;
+    CurrentLeafFrame = CurrentLeafFrame->Parent;
+  }
----------------
hoy wrote:
> nit: switch the two statements for readability? A comment would also be helpful.
iiuc, switching changes the semantic though - we will be checking IsArtificialFrame the grand parent instead of parent ..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115550/new/

https://reviews.llvm.org/D115550



More information about the llvm-commits mailing list