[PATCH] D115413: [amdgpu] Drop lowering of LDS used by global variables

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

Yes, agreed. The address of an LDS variable is scoped to the kernel execution, thus some other LDS variable could be initialised with it. Fortunately, LDS have undef as an initialiser (which is also checked before this call), so that edge case can be postponed until implementing initializers for LDS.



================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPULDSUtils.cpp:123
     }
     if (!isa<UndefValue>(GV.getInitializer())) {
       // Initializers are unimplemented for LDS address space.
----------------
LDS with non-undef init skipped over here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115413/new/

https://reviews.llvm.org/D115413