[PATCH] D102591: Fix DIObjCProperty getter and setter swapped during parsing
Hasyimi Bahrudin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 12 04:13:57 PST 2021
hasyimibhar updated this revision to Diff 393740.
hasyimibhar added a comment.
Rebase to main
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102591/new/
https://reviews.llvm.org/D102591
Files:
llvm/lib/AsmParser/LLParser.cpp
llvm/test/Assembler/diobjcproperty.ll
Index: llvm/test/Assembler/diobjcproperty.ll
===================================================================
--- llvm/test/Assembler/diobjcproperty.ll
+++ llvm/test/Assembler/diobjcproperty.ll
@@ -1,5 +1,6 @@
; RUN: llvm-as < %s | llvm-dis | llvm-as | llvm-dis | FileCheck %s
; RUN: verify-uselistorder %s
+; RUN: opt -S < %s | FileCheck %s
; CHECK: !named = !{!0, !1, !2, !3, !4, !4}
!named = !{!0, !1, !2, !3, !4, !5}
Index: llvm/lib/AsmParser/LLParser.cpp
===================================================================
--- llvm/lib/AsmParser/LLParser.cpp
+++ llvm/lib/AsmParser/LLParser.cpp
@@ -5109,16 +5109,16 @@
OPTIONAL(name, MDStringField, ); \
OPTIONAL(file, MDField, ); \
OPTIONAL(line, LineField, ); \
- OPTIONAL(setter, MDStringField, ); \
OPTIONAL(getter, MDStringField, ); \
+ OPTIONAL(setter, MDStringField, ); \
OPTIONAL(attributes, MDUnsignedField, (0, UINT32_MAX)); \
OPTIONAL(type, MDField, );
PARSE_MD_FIELDS();
#undef VISIT_MD_FIELDS
Result = GET_OR_DISTINCT(DIObjCProperty,
- (Context, name.Val, file.Val, line.Val, setter.Val,
- getter.Val, attributes.Val, type.Val));
+ (Context, name.Val, file.Val, line.Val, getter.Val,
+ setter.Val, attributes.Val, type.Val));
return false;
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102591.393740.patch
Type: text/x-patch
Size: 1649 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211212/28f7c569/attachment-0001.bin>
More information about the llvm-commits
mailing list